Repository navigation
Fix immutable OIDC subjects for new repositories - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New repositories use GitHub’s immutable default OIDC subject (
repo:OWNER@OWNER_ID/REPO@REPO_ID:environment:ENV). A disposable live acceptance run failed both prepare and publish withoidc_subject_mismatch: repository OIDC metadata confirmed this new default, while the broker only accepted the legacy name-only format. No inference ran.Accept exactly the documented immutable default alongside the legacy default. Derive both numeric IDs and names from the already verified expected tenant; keep exact Environment encoding and all issuer, audience, signature, caller/ref, immutable reusable workflow, actor/run and dispatch checks. Custom templates and wrong IDs remain rejected. No secret, session, migration, runner or reusable-workflow change; keep the synchronized trusted review SHA unchanged.
Validation: full Node 24 check (195 tests), including cryptographically signed immutable subjects for review/publish and encoded Environments, negative wrong owner/repository IDs and names, extra suffixes, stage and workflow mismatches. Full GitHub CI remains required before the authorized normal merge/deployment.
Official contract: https://docs.github.com/en/actions/reference/security/oidc#immutable-subject-claims